Skip to content

Add support for parsing database entities including hyphens #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2024
Merged

Add support for parsing database entities including hyphens #7

merged 2 commits into from
Jun 13, 2024

Conversation

ondrejromancov
Copy link

@ondrejromancov ondrejromancov commented Jun 11, 2024 •
edited
Loading

🎉

How did I do it:

  1. Adding a hyphen to getLastToken is obvious
  2. I pasted the parse.pegjs file into ChatGPT and asked where I should add support for entities containing a hyphen
  3. ChatGPT pointed me towards ident_part
  4. I regenerated the parser with npm build

@ondrejromancov ondrejromancov requested a review from the21st June 11, 2024 14:34
the21st
the21st approved these changes Jun 13, 2024
View reviewed changes
Copy link

@the21st the21st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, great job! This was more complicated than I anticipated (having to look at pegjs)

@ondrejromancov ondrejromancov merged commit 24b6a2d into release Jun 13, 2024
@ondrejromancov ondrejromancov deleted the orom/support-parsing-database-entities-with-hyphens branch June 13, 2024 12:56
This was referenced Jun 13, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@the21st the21st the21st approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ondrejromancov @the21st